[Bug-readline] Build problem on OS X Leopard (Readline 5.2), plus fix

[Han Kessels]

Readline 5.2 does not build on OS X Leopard (10.5).
./configure --prefix=/usr/local
make
=>

gcc -dynamic -arch_only `/usr/bin/arch` -install_name /usr/local/lib/libreadline.5.2.dylib -current_version 5.2
 -compatibility_version 5 -v -o libreadline.5.2.dylib readline.so vi_mode.so funmap.so keymaps.so parens.so search.so rltty.so complete.so bind.so isearch.so display.so signals.so util.so kill.so undo.so macro.so input.so
 callback.so terminal.so text.so nls.so misc.so xmalloc.so history.so histexpand.so histfile.so histsearch.so shell.so mbutil.so tilde.so compat.so -lncurses
Using built-in specs.
Target: i686-apple-darwin9
Configured with: /var/tmp/gcc/gcc-5465~16/src/configure --disable-checking -enable-werror --prefix=/usr --mandir=/share/man --enable-languages=c,objc,c++,obj-c++ --program-transform-name=/^[cg][^.-]*$/s/$/-
4.0/ --with-gxx-include-dir=/include/c++/4.0.0 --with-slibdir=/usr/lib --build=i686-apple-darwin9 --with-arch=apple --with-tune=generic --host=i686-apple-darwin9 --target=i686-apple-darwin9
Thread model: posix
gcc version 
4.0.1 (Apple Inc. build 5465)
i686-apple-darwin9-gcc-4.0.1: -compatibility_version only allowed with -dynamiclib
make[1]: *** [libreadline.5.2.dylib] Error 1
make: [shared] Error 2 (ignored)

The reason is an explicit OS version check in support/shobj-conf that does not include darwin9 (
i.e. OS X 10.5 Leopard).
Here is a patch:

-- support/shobj-conf    2007-12-26 18:30:46.000000000 +0900
+++ support/shobj-conf.new    2007-12-26 18:30:39.000000000 +0900
@@ -142,7 +142,7 @@
     ;;
 
 # Darwin/MacOS X
-darwin8*)
+darwin89*)
     SHOBJ_STATUS=supported
     SHLIB_STATUS=supported
     
@@ -171,7 +171,7 @@
     SHLIB_LIBSUFF='dylib'
 
     case "${host_os}" in
-    darwin[78]*)    SHOBJ_LDFLAGS=''
+    darwin[789]*)    SHOBJ_LDFLAGS=''
             SHLIB_XLDFLAGS='-dynamiclib -arch_only `/usr/bin/arch` -install_name $(libdir)/$@ -current_version $(SHLIB_MAJOR)$(SHLIB_MINOR) -compatibility_version $(SHLIB_MAJOR) -v'
             ;;
     *)        SHOBJ_LDFLAGS='-dynamic'


Cheers,

Han Kessels