bug-patch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint: Use gnulib's xbinary-io module.


From: Collin Funk
Subject: Re: maint: Use gnulib's xbinary-io module.
Date: Sat, 15 Jun 2024 17:41:27 -0700
User-agent: Mozilla Thunderbird

Hi Bruno,

Bruno Haible wrote:
>> What do you think of the following two patches?
> 
> I'm not Andreas, but if I may comment on it:

Always appreciated.

> The only things I would do differently:
> 
> 1) If binary_transput is of type bool, the comment
>   /* O_BINARY if binary i/o is desired */
> is no longer correct. In order to reduce the amount of conditional
> expressions, I would preserve the comment and go back to 'int' rather
> than 'bool'.

Oops, yes the comment would be inaccurate. I prefer bool since it is
more clear than an int which can only be  0 or O_BINARY, IMO. But that
is just personal opinion and I assume others would dislike the
conditionals too.

I've attached a fixed patch that sticks to the previous method of 0 or
O_BINARY.

Collin

Attachment: v2-0002-maint-Use-gnulib-s-xbinary-io-module.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]