[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] [PATCH] build: don't use -Werror in AM_INIT_AUTOMAKE
From: |
Jim Meyering |
Subject: |
Re: [bug-patch] [PATCH] build: don't use -Werror in AM_INIT_AUTOMAKE |
Date: |
Wed, 01 May 2013 03:35:42 +0200 |
Stefano Lattarini wrote:
> On 04/24/2013 01:19 PM, Stefano Lattarini wrote:
>> Doing so prevents bootstrapping with bleeding-edge autotools,
>> because of harmless deprecation warnings (that are not planned
>> to become hard errors for at least a few years to come). And
>> unfortunately, options in AM_INIT_AUTOMAKE take precedence over
>> those given on the command line (this is a long-time wart of
>> automake).
>>
>> * configure.ac (AM_INIT_AUTOMAKE): Drop '-Werror' option.
>>
>> Copyright-paperwork-exempt: yes
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>> configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index dc837d6..f078469 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -33,7 +33,7 @@ AM_CONDITIONAL([ENABLE_MERGE], [test "$enableval" != no])
>> AM_CONDITIONAL([ALPHA_VERSION],
>> [[echo "$PACKAGE_VERSION" | grep -- "-[0-9a-f][0-9a-f]*\\(-dirty\\)\\?$"
>> >/dev/null]])
>>
>> -AM_INIT_AUTOMAKE([1.11.2 -Wall -Werror gnu dist-bzip2 dist-xz color-tests
>> parallel-tests])
>> +AM_INIT_AUTOMAKE([1.11.2 -Wall gnu dist-bzip2 dist-xz color-tests
>> parallel-tests])
>> AM_SILENT_RULES([yes])
>>
>> AC_CONFIG_HEADER([config.h:config.hin])
>>
> Ping?
Hi Stefano,
Thanks for the patch! It looks fine to me and I'll push it
late Wed (today) if no one objects in the mean time.