[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] patch-2.7 forgets to rename backup to original, upon fai
From: |
Jim Meyering |
Subject: |
Re: [bug-patch] patch-2.7 forgets to rename backup to original, upon failure? |
Date: |
Thu, 13 Sep 2012 17:06:44 +0200 |
Andreas Grünbacher wrote:
> 2012/9/12 Jim Meyering <address@hidden>:
>> This takes place on automake's "maint" branch:
>> commit 9c4ad6973eedb074a9381e14a6c1eeeb285c2465
>>
>> It looks like when patch application fails, patch renames the
>> target to the backup name, FILE.~1~, but doesn't move it back,
>> appearing to remove the target:
>
> hmm, this happens with git-style diffs when the original file doesn't
> change. Could you have a look at the testing branch, please?
Hi Andreas,
Thanks for the quick fix.
I confirm that patch build from the current testing branch
(v2.7-4-gf0388d2) no longer has the problem I reported.
A minor suggestion: I find that it is worthwhile to
include a NEWS update in any commit that fixes a bug.
Then, I have far less work to do at release time,
(not to mention less risk that I'll forget to mention something)
since all significant summaries have already been added to NEWS.