bug-patch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] Time for a new release?


From: Andreas Gruenbacher
Subject: Re: [bug-patch] Time for a new release?
Date: Tue, 17 Apr 2012 18:15:40 +0200
User-agent: KMail/1.12.4 (Linux/2.6.36-rc7+; KDE/4.3.5; i686; ; )

Jean,

On Monday 16 April 2012 19:21:41 Jean Delvare wrote:
> On Monday 16 April 2012 06:08:42 pm Andreas Grünbacher wrote:
> > Am 16. April 2012 15:35 schrieb Jean Delvare <address@hidden>:
> > > So with the latest version of GNU patch, every "quilt push" results
> > > in a warning about read-only files. This is rather inconvenient and
> > > passing --quiet doesn't even make it go away. And "quilt push -f"
> > > fails. Bad.
> > 
> > Why does "quilt push -f" fail?
> 
> This is somewhat unintuitive (I had to check the code twice myself) but 
> "quilt push" calls "patch -f" while "push -f" calls "patch" (no -f). And 
> new version of "patch" fails on read-only files unless forced, so now 
> "quilt push -f" fails on read-only files.

I see.  This may be the only way to allow GNU patch to run interactively.  I'm 
not sure how much that is worth though ...

> Maybe we could use "patch -f" always, I'm not sure. But even then, 
> "patch" now displays a warning message, which can't be suppressed, so it 
> won't completely help.

The new read-only check has also bitten others before; this change seems too 
problematic.  I have reduced it to a warning now; it can be silenced with --
read-only=ignore or turned into a failure with --read-only=fail.  Hopefully 
that will work well enough now.

Can you give the current snapshot a try?

Thanks,
Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]