[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] [PATCH 1/2] build: include .version in tarball to avoid
Re: [bug-patch] [PATCH 1/2] build: include .version in tarball to avoid distcheck failure
Thu, 11 Aug 2011 14:20:27 +0200
Andreas Gruenbacher wrote:
> On Wed, 2011-08-10 at 16:55 +0200, Jim Meyering wrote:
>> Here are two patches:
>> The first prevents make distcheck failure,
>> and the second helps Mac OS 10.5 users who use patch
>> to operate on very large files.
> both patches look reasonable.
Thanks for the review. Pushed.
> Can you add .tarball-version to .gitignore as well as suggested in
For reference, here is the comment:
# It is probably wise to add these two files to .gitignore, so that you
# don't accidentally commit either generated file.
That comment is borderline erroneous.
It gives good advice wrt .version, but not for .tarball-version.
I've just corrected it in gnulib:
Because .tarball-version is never generated in a git-controlled
directory, there is no risk that it would be accidentally VC-added.
And anyone who VC-adds the contents of a distribution tarball
will end up with a lot more to regret than one extra dot file.