[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] [PATCH 00/15] *** SUBJECT HERE ***
From: |
Andreas Gruenbacher |
Subject: |
Re: [bug-patch] [PATCH 00/15] *** SUBJECT HERE *** |
Date: |
Sat, 26 Mar 2011 23:14:55 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.34.7-0.4-desktop; KDE/4.4.4; x86_64; ; ) |
Jim,
On Saturday 26 March 2011 14:31:55 Jim Meyering wrote:
> In the interest of getting patch into a form
> that will integrate more easily with diffutils,
> here are some changes that make most of gnulib's
> syntax-check rules pass (the others are skipped for now).
>
> The changes cover a mixture of style, portability, safety,
> and increasing consistency with other GNU packages.
thanks, I like this. I only have one nit-picking comment.
> Jim Meyering (15):
> maint: use gnulib's maintainer-makefile module
> maint: arrange for the sc_require_config_h_first test to pass
> maint: add some m4 quoting
> maint: remove trailing blanks
> maint: allow the sc_prohibit_empty_lines_at_EOF test to pass
> maint: avoid non-portable use of test -a
> build: accept new configure-time option --enable-gcc-warnings
> tests: temporarily disable failing syntax-check rules
You have sc_prohibit_always-defined_macros in local-checks-to-skip twice here.
> build: avoid three gcc warnings
> maint: update copyright date year ranges to include 2011
> maint: update bootstrap and gnulib submodule
> maint: use gnulib's progname module
> maint: remove now-unneeded macro definitions
> build: don't turn off -Wmissing-prototypes
> build: don't turn off -Wmissing-declarations
Andreas
- [bug-patch] [PATCH 15/15] build: don't turn off -Wmissing-declarations, (continued)
- [bug-patch] [PATCH 15/15] build: don't turn off -Wmissing-declarations, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 13/15] maint: remove now-unneeded macro definitions, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 14/15] build: don't turn off -Wmissing-prototypes, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 05/15] maint: allow the sc_prohibit_empty_lines_at_EOF test to pass, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 07/15] build: accept new configure-time option --enable-gcc-warnings, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 06/15] maint: avoid non-portable use of test -a, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 11/15] maint: update bootstrap and gnulib submodule, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 12/15] maint: use gnulib's progname module, Jim Meyering, 2011/03/26
- [bug-patch] [PATCH 10/15] maint: update copyright date year ranges to include 2011, Jim Meyering, 2011/03/26
- Re: [bug-patch] [PATCH 00/15] *** SUBJECT HERE ***,
Andreas Gruenbacher <=