bug-patch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-patch] [PATCH] do not validate target name when it is specified


From: Andreas Gruenbacher
Subject: Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line
Date: Thu, 17 Feb 2011 09:49:12 +0100
User-agent: KMail/1.13.5 (Linux/2.6.34.7-0.4-desktop; KDE/4.4.4; x86_64; ; )

On Thursday 17 February 2011 09:25:57 Jim Meyering wrote:
> Andreas Gruenbacher wrote:
> > On Wednesday 16 February 2011 18:03:21 Jim Meyering wrote:
> >> Here's a better patch.
> >
> > Nice.  Now we can suppress warnings for equal filenames too for even fewer
> > confusing warnings.  Here is your last patch + some coding style changes +
> > actually comparing filenames + test case.
> 
> Good improvements.  I usually put a space between the "!!" operator
> and its operand, too.
> 
> I noticed that we can avoid a useless comparison in the common case,

IMO it's not worth it.

Can you put the rest in, also to see if you have proper push access to the 
repo?

Thanks,
Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]