[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-patch] [PATCH] do not validate target name when it is specified
From: |
Jim Meyering |
Subject: |
Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line |
Date: |
Mon, 14 Feb 2011 07:14:19 +0100 |
Andreas Gruenbacher wrote:
> On Thursday 10 February 2011 13:19:54 Jim Meyering wrote:
>> There are several ways to fix it...
>
> That's true about this entire issue ...
>
> In the current heuristic to determine which file to patch [*], we could also
> skip absolute filenames and filenames with ".." components, and maybe warn if
> those filenames would have been chosen. That way we would end up with the
> usual "File to patch:" question in interactive mode, which would be more in
> line with patch's historic behavior.
Can you give an example in which patch would have
selected a bad name, yet there is still a reason to prompt?
I confess I'm biased: I do not like being prompted, and if there's
anything suspicious about a patch, I'd rather avoid the prompt
altogether.
- [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/10
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/13
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line,
Jim Meyering <=
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/14
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/14
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/14
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/14
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/15
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/16
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/16
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/16
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Andreas Gruenbacher, 2011/02/16
- Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line, Jim Meyering, 2011/02/16