[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/2] maint: remove unreachable code
From: |
Jim Meyering |
Subject: |
[PATCH 1/2] maint: remove unreachable code |
Date: |
Fri, 27 May 2011 07:53:52 +0200 |
FYI, I've just pushed these two changes:
(only to the new savannah repository, for now)
>From 38a716b1e88bea53a41aac2dcaf54f68f031edff Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 24 May 2011 16:54:51 +0200
Subject: [PATCH 1/2] maint: remove unreachable code
* libparted/labels/sun.c (sun_partition_new): Remove unreachable stmt.
* libparted/labels/pc98.c (pc98_partition_new): Likewise.
---
libparted/labels/pc98.c | 1 -
libparted/labels/sun.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/libparted/labels/pc98.c b/libparted/labels/pc98.c
index 5a720db..3afa8a2 100644
--- a/libparted/labels/pc98.c
+++ b/libparted/labels/pc98.c
@@ -541,7 +541,6 @@ pc98_partition_new (
}
return part;
- free (pc98_data);
error_free_part:
free (part);
error:
diff --git a/libparted/labels/sun.c b/libparted/labels/sun.c
index e674bb6..75f7c6e 100644
--- a/libparted/labels/sun.c
+++ b/libparted/labels/sun.c
@@ -518,7 +518,6 @@ sun_partition_new (const PedDisk* disk, PedPartitionType
part_type,
return part;
- free (sun_data);
error_free_part:
free (part);
error:
--
1.7.5.2.660.g9f46c
>From 36896335b4439550f5d91bf79b296dc1b421b22a Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 24 May 2011 16:57:57 +0200
Subject: [PATCH 2/2] maint: correct coverity-reported "suspicious sizeof"
* parted/table.c (table_add_row): Use sizeof(*VAR), rather than
erroneous sizeof(explicit_type) that just happened to be ok.
---
parted/table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/parted/table.c b/parted/table.c
index efafaa9..cb1d447 100644
--- a/parted/table.c
+++ b/parted/table.c
@@ -135,7 +135,7 @@ void table_add_row (Table* t, wchar_t** row)
printf("[%s]", row[i]);
putchar ('\n');*/
- t->rows = xrealloc (t->rows, (t->nrows + 1) * sizeof(wchar_t***));
+ t->rows = xrealloc (t->rows, (t->nrows + 1) * sizeof(*(t->rows)));
t->rows[t->nrows] = row;
--
1.7.5.2.660.g9f46c
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH 1/2] maint: remove unreachable code,
Jim Meyering <=