[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH parted 2/5] linux.c: save blkid topology in arch_specific dat
From: |
Jim Meyering |
Subject: |
Re: [PATCH parted 2/5] linux.c: save blkid topology in arch_specific data for later use |
Date: |
Wed, 28 Oct 2009 22:57:02 +0100 |
Hans de Goede wrote:
> This is a preparation patch for adding get_minimal_alignment
> and get_optimal_alignment functions to linux's _PedDeviceArchOps.
> ---
> libparted/arch/linux.c | 75
> ++++++++++++++++++------------------------------
> libparted/arch/linux.h | 8 +++++
> 2 files changed, 36 insertions(+), 47 deletions(-)
>
> diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
...
> +#if USE_BLKID
> + if (arch_specific->probe)
> + blkid_free_probe (arch_specific->probe);
> +#endif <<<---- trailing blanks
Hi Hans,
Thanks for working on this.
Please run "make syntax-check" if not "make distcheck",
and it will highlight nits like the above trailing blanks.
Also, please add at least one ChangeLog-style mention per
modified file/function pair in the commit log.
I'll look at the rest of these changes tomorrow.
Please consider adding a scsi_debug-based test script or two
(or at least outlines), to exercise the alignment_offset changes.
Jim