Re: Parted 1.6.22

[Andrew Clausen]

On Sun, Mar 20, 2005 at 05:25:21PM +0100, Sven Luther wrote:
> On Sun, Mar 20, 2005 at 11:03:18AM +1100, Andrew Clausen wrote:
> > 2005-03-07  Chris Lumens  <address@hidden>
> > * libparted/disk_mac.c: support LVM on PPC by setting the proper flags on 
> > the
> >   partition (patch from Paul Nasrat <address@hidden>).
> 
> For information, i disagree with this fix.
> 
> It set the partition name to lvm, while apple has the concept of partition
> type. It was decided to use the partition types Linux_LVM and Linux_RAID for
> these two issues, and not the partition name, which users may which to set to
> their own values, or otherwise use.
> 
> The Linux_LVM and Linux_RAID where tested on various mac os implementation,
> and they don't cause any special kind of problems there.
> 
> This is also in accordance with the x86 code, which uses a partition type for
> this kind of thing, and not a flag (like boot or hidden). Using a name for it
> is counter-intuitive, and does not respect the user's right to modify the
> partition names themselves.

Agreed.  I obviously didn't read the patch properly.

I have just committed the implementation you suggested to CVS.  I did
this for both LVM and RAID.  Please let me know if it looks ok.

Cheers,
Andrew