Re: Parted 1.6.5-pre1

[Andrew Clausen]

On Tue, Jan 07, 2003 at 06:22:55PM +0530, Veerapuram Varadhan wrote:
> > I guess Parted could include some warnings... I'm accepting patches...
> 
> Thats a cool idea.  Do you have those patches already or shall i send you
> one? ;-)

I don't have any such patches already :P

> If i have to submit a patch, guide me about your procedures regarding
> comments, changelog and coding style and also how to generate the patch.

comments: be as liberal as you like with them... but try to make
the code speak for itself also :)

changelogs: Please include changelog entries (in the same format
as ChangeLog) in your emails containing the actual patch(es).

coding style: try to follow a similar style... same tab-size, etc.,
most functions shouldn't be longer than about 20 lines, avoid
using variables (as opposed to constants), etc.

Generating patches:

        tar zxvf parted-1.6.5-pre1.tar.gz
        mv parted-1.6.5-pre1 parted-work
        tar zxvf parted-1.6.5-pre1.tar.gz
        [edit parted-work]
        diff -rup parted-1.6.5-pre1 parted-work

You may find it useful to compile in a different directory to the
source directory:

        mkdir build
        cd build
        CFLAGS=-g ../parted-work/configure && make

Cheers,
Andrew