Re: [Bug-parted] Re: parted 1.3.x errata

[Damien Genet]

Salut,

Andrew Clausen wrote:
> > the func should, maybe, return true to PED_PARTITION_HIDDEN
> > only for FAT, and false for PED_PARTITION_BOOT when
> > partition is extended.
> 
> Hmmm.  I guess I should do this :-/  It's ugly.  Added to TODO,
> pending further sleepness nights.

I join a diff, code is untested (Gtk-Parted is still broken due to
libparted 1.3.x port), modifications should also be applied
to disk_pc98, but I don't know how much this architecture
(is it the right word?) differs from a standard PC.

> > Is it possible to know what flags would be available before creating
> > a partition?
> 
> Interesting question.  Perhaps I should make it policy, that if you
> pass NULL as the "part" argument to ped_partitition_is_flag_available(),
> then it should return some reasonable values.  Added to TODO.

the problem is that if part is NULL, you can't know on what disk type
you wan't to add the partition... and so you can't know
what flags are available.
maybe direct use of disk->type->ops->partition_is_flag_available()
should be better, or this call could also be in a
ped_disk_is_flag_available(PedDisk *disk, PedPartitionFlag flag)
funtion.


Thanks,
Dam