Re: [Bug-ocrad] Version 0.21-pre1 of GNU Ocrad released

[Tilman Hausherr]

Hello Antonio,

- The crashes seem to be solved, i.e. the problem-images don't crash. I
did not look into the source to check whether you used my "symptom"
fixes or made your own or both, because you certainly know what you're
doing.
- You didn't make the changes in main.cc. I know there's one you don't
want to make ("wx" problem), but the other (setmode binary) I thought
you wanted to make?! (I see you already answered)
- I tested the six benchmark images and the output is identical.
- I tested a fixed set of images (about 70) with the new and the old
software, there's no difference in the words output that I get after
postprocessing.
- I tested with Visual C++, not gcc or mingw.
- I did not test more "noisy" images today except the known problem
images, maybe monday.

Another change you might want to make is to start to eliminate some
warnings:

page_image.cc, in otsu_th

replace
        const double cmom_max = cmom[maxval];
with
        const double cmom_max = (double) cmom[maxval];

in rational.cc, Rational::to_decimal

replace
        { rest *= 10; s += '0' + ( rest / den ); rest %= den; --prec; }
with
        { rest *= 10; s += '0' + (char) ( rest / den ); rest %= den;
--prec; }


in common.cc, Charset::enabled

change
        return charset_ & cset;
to
        return (charset_ & cset) != 0;


there are more warnings (especially when compiling for 64bit, because
you're not using size_t type for numbers based on sizes), but this is a
small start. While most warnings are just that, they "mask" warnings
that might really have a meaning, and they're scary for newbies.

Tilman

On Thu, 19 Aug 2010 16:38:05 +0200, Antonio Diaz Diaz wrote:

>Version 0.21-pre1 of GNU Ocrad is ready for testing here
>http://download.savannah.gnu.org/releases/ocrad/ocrad-0.21-pre1.tar.gz
>http://download.savannah.gnu.org/releases/ocrad/ocrad-0.21-pre1.tar.lz
>
>Please, test it and report any bugs you find.
>
>Ocrad is the GNU OCR (Optical Character Recognition) program.
>
>The homepage is at http://www.gnu.org/software/ocrad/ocrad.html
>
>This version is also available in lzip format. If your distro doesn't
>yet distribute the lzip program, you can download it from
>http://www.nongnu.org/lzip/lzip.html
>
>The md5sums are:
>b950a1914e59c18b70fb18df7fbb1f6a  ocrad-0.21-pre1.tar.gz
>bfb2038b00b5dd5001e77bd03e7a1ece  ocrad-0.21-pre1.tar.lz
>
>
>Changes in this version:
>
>   * Some internal errors triggered by noisy input have been fixed.
>
>
>Regards,
>Antonio Diaz, GNU Ocrad author and maintainer.
>
>
>_______________________________________________
>Bug-ocrad mailing list
>address@hidden
>http://lists.gnu.org/mailman/listinfo/bug-ocrad