Re: [bug-ncurses] API change with macro KEY_EVENT?

[Dr. Werner Fink]

On 2020/08/14 05:40:05 -0400, Thomas Dickey wrote:
> On Fri, Aug 14, 2020 at 09:42:40AM +0200, Dr. Werner Fink wrote:
> > On 2020/08/14 09:39:31 +0200, Dr. Werner Fink wrote:
> > > Hi,
> > > 
> > > I've a report from our build team doing a stage test (rebuilding all tools
> > > with new libraries and/or compilers):
> > > 
> > > | Visit https://build.opensuse.org/request/show/825926
> > > | 
> > > | Dominique Leuenberger wrote in request 825926:
> > > | 
> > > |
> > > | [  128s] In file included from curkeys.cc:30:
> > > | [  128s] curkeys.h:168:5: error: 'KEY_EVENT' was not declared in this 
> > > scope; did you mean 'KEY_OPEN'?
> > > | [  128s]   168 |   { KEY_EVENT,      "Event"               },
> > > | [  128s]       |     ^~~~~~~~~
> > > | [  128s]       |     KEY_OPEN
> > > 
> > > What had happen to KEY_EVENT
> > 
> > It should be noted that I do not care about Visual C++ :)
> > and the change for this compiler breaks tools here:
> > 
> > | Dominique Leuenberger wrote in request 825926:
> > | 
> > | [@WernerFink](https://build.opensuse.org/users/WernerFink)
> > | 
> > | breaks at least dpkg and zsh (KEY_EVENT changes)
> 
> well, to make some case for changing it, we have to find the scenario
> where the program logic is using it.  Otherwise, the problematic line(s)
> in the program can be discarded :-)

Hmmm .... those packages do fail in staging test:

 apparmor       failed
 ceph   failed
 dpkg   failed
 grantlee5      failed
 kbuild failed
 kdelibs4support        failed
 libappindicator:gtk3   failed
 libarchive     failed
 memcached      failed
 meson:test     failed
 python-pytest-django   failed
 speech-dispatcher      failed
 tcpd   failed
 zsh    failed

... do I've revert the change for Visual C++ for OpenSUSE to get
then to compile again?

Werner

-- 
  "Having a smoking section in a restaurant is like having
          a peeing section in a swimming pool." -- Edward Burr

signature.asc
Description: PGP signature