bug-ncurses
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

"-I/usr/include/" in .pc


From: Daiki Ueno
Subject: "-I/usr/include/" in .pc
Date: Mon, 29 Jun 2015 17:44:37 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Hello,

When ncurses is compiled with:

  ./configure --enable-pc-files --includedir=/usr/include/foobar

The generated PC files contain superfluous -I/usr/include/:

  misc/formw.pc:Cflags:  -D_GNU_SOURCE -I/usr/include/ -I${includedir}
  misc/menuw.pc:Cflags:  -D_GNU_SOURCE -I/usr/include/ -I${includedir}
  misc/ncurses++w.pc:Cflags:  -D_GNU_SOURCE -I/usr/include/ -I${includedir}
  misc/ncursesw.pc:Cflags:  -D_GNU_SOURCE -I/usr/include/ -I${includedir}
  misc/panelw.pc:Cflags:  -D_GNU_SOURCE -I/usr/include/ -I${includedir}

Since the gen-pkgconfig script checks for "$includedir" !=
"/usr/include", I suspect that they are mistakenly added, because of the
final "/".  How about the following change?

--- misc/gen-pkgconfig.in~      2015-06-29 17:30:16.621104506 +0900
+++ misc/gen-pkgconfig.in       2015-06-29 17:30:41.429276349 +0900
@@ -66,7 +66,7 @@
 
 CFLAGS="@PKG_CFLAGS@"
 if test "$includedir" != "/usr/include" ; then
-       includetop=`echo "$includedir" | sed -e 's,/include/[^/]*$,/include/,'`
+       includetop=`echo "$includedir" | sed -e 's,/include/[^/]*$,/include,'`
        test "$includetop" = "/usr/include" && includetop="$includedir"
        if test "x$includetop" != "$includedir"
        then

Regards,
-- 
Daiki Ueno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]