[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in _nc_timed_wait ncurses 5.7

From: Thomas Dickey
Subject: Re: bug in _nc_timed_wait ncurses 5.7
Date: Mon, 6 Apr 2009 17:11:21 -0400 (EDT)

On Mon, 6 Apr 2009, David Grothe wrote:

Thomas Dickey wrote:
On Mon, 6 Apr 2009, David Grothe wrote:

In file ncurses/tty/lib_twait.c line 251 '&' is used without proper ()-s.

                  if (fds[c].fd == ev->data.fev.fd
                      && fds[c].revents & POLLIN) {

I see that it builds without warnings in one of my weekly build-logs.

(the build is using poll in the current log, though occasionally the configure check decides to use select...)

Is gcc not warning when it should?
No warning. But the gcc command line does not seem to have anything like -Wall on it either.

I do all of my builds using --enable-warnings (and --disable-echo).

barring ongoing development -
The only warnings in the Linux builds are const-mismatches that I can't get rid of, e.g., references to things that are almost always readonly, but are malloc'd.

make[1]: Entering directory `/data/gcom/gcom/rsys/linux/ncurses-5.7/ncurses'
gcc -DHAVE_CONFIG_H -I../ncurses -I. -I. -I../include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DNDEBUG -I/usr/local/include/ncurses -O2 -c .../ncurses/./tty/lib_twait.c -o ../objects/lib_twait.o
ar rv ../lib/libncurses.a ../objects/lib_twait.o
r - ../objects/lib_twait.o
ranlib ../lib/libncurses.a
make[1]: Leaving directory `/data/gcom/gcom/rsys/linux/ncurses-5.7/ncurses'

Question: Is there documentation somewhere for wgetch_events() and its event list parameter?

There's a file in the sources: ncurses/README.IZ
Thanks, I see it now.

no problem

-- Dave

Thomas E. Dickey

reply via email to

[Prev in Thread] Current Thread [Next in Thread]