Re: Corrections for 20020907

[Thomas Dickey]

On Mon, Sep 09, 2002 at 06:40:11AM +0200, Philippe Blain wrote:
> >From Philippe Blain, Bordeaux, FRANCE.
> My old computer: P133 - 8,4 Go - 32 Mo Red Hat Linux 7.0
> 
> To maintainers of 'ncurses'.(and to Mr Dickey)
> Subject: Corrections for ncurses-5.2-20020907+
> 
> Here are some problems I found :
> 
> ----------------------------------------------------------------------------
> File : ncurses/base/lib_screen.c
> Function : putwin()
> 
> Line 117,       ******  change chtype to NCURSES_CH_T  *******
> 
>     for (n = 0; n <= win->_maxy; n++) {
> ==>     if (fwrite(win->_line[n].text, sizeof(NCURSES_CH_T), len, filep) !=
> len
>         || ferror(filep))
>           returnCode(code);
>     }

ok - did that
 
> ----------------------------------------------------------------------------
> ----
> File : ncurses/base/lib_screen.c
> Function : getwin()
> 
> delwin() can delete a pad.
> subwin() can create a subpad from a pad.
> derwin() idem.
> Ok, so saving and restoring a PAD should be possible, too.
> Just add some lines :

ok - I verified that Solaris allows putwin to operate on a pad.
Didn't check dupwin, but it looks harmless...

> Modify putwin().
> Same thing can be done on dupwin(), duplicating a PAD.
> 
> ----------------------------------------------------------------------------
> ----
> File : ncurses/tty/lib_mvcur.c
> 
> Line 951
> Cleaning these useless variables in the movement optimizer code :
> 
> NCURSES_EXPORT_VAR(const char *) _nc_progname = "mvcur";

_nc_progname is used - the others don't appear to be any longer

> ----------------------------------------------------------------------------
> ** PADDING **
> 
> Think the configure option --enable-no-padding could be dropped.

it defaults to "on", and since it's an extension, should be configurable.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net