bug-myserver
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-myserver] [Bugfix] myserver.cpp


From: Giuseppe Scrivano
Subject: Re: [bug-myserver] [Bugfix] myserver.cpp
Date: Sat, 27 Mar 2010 22:37:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.93 (gnu/linux)

Thank you!

I am going to apply it.  Just few comments:

the commit message was too long, I have shortened it to fit in 76
characters (plus the 4 characters used by git log to indent the commit
messsage, we have 80), moving the detail to the second line:

Refactor the code that checks if the server is called with an absolute path.
    
The `updateWorkingDirectory' method was extracted from `main'.

> +static void updateWorkingDirectory(const char *firstArgument)

We leave an empty space between the function name and '(', so:

static void updateWorkingDirectory (const char *firstArgument)


> +  /* Move to a different working directory, if necessary. */

We leave two spaces after a dot, like:

/* Move to a different working directory, if necessary.  */


I have amended these oh-they-are-just-details changes to your patch.

Cheers,
Giuseppe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]