bug-mes
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use long-r when extending unsigned 4-byte integers.


From: Janneke Nieuwenhuizen
Subject: Re: [PATCH] Use long-r when extending unsigned 4-byte integers.
Date: Sat, 27 Jan 2024 19:53:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Andrius tikonas writes:

Hi!

> * module/mescc/compile.scm: use long-r instead of long-signed-r
> ---
>  module/mescc/compile.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/mescc/compile.scm b/module/mescc/compile.scm
> index 3135ec9c..87c6d4f7 100644
> --- a/module/mescc/compile.scm
> +++ b/module/mescc/compile.scm
> @@ -1485,7 +1485,7 @@
>                 (wrap-as (as info 'long-signed-r)))
>                ((and (> reg-size 4) (= size 4))
>                 ;; for 17-unsigned-le
> -               (wrap-as (as info 'long-signed-r))  ; huh, why not long-r?
> +               (wrap-as (as info 'long-r))
>                 ;; for a0-call-trunc-int
>                 ;;(wrap-as (as info 'long-r))
>                 )

As discussed on IRC, I've applied it to `wip' for now, but it makes two
tests fail on x86_64:

    mescc-lib/lib/tests/scaffold/16-cast 
    [2]19:47:07 janneke@drakenpad:~/src/mes/wip-x86_64

    mescc-lib/lib/tests/scaffold/17-compare-unsigned-le
    [1]19:45:39 janneke@drakenpad:~/src/mes/wip-x86_64 

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]