[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: i386 backend: i386:r-word-mem-add immediate size specifier in name
|
From: |
Jan Nieuwenhuizen |
|
Subject: |
Re: i386 backend: i386:r-word-mem-add immediate size specifier in name |
|
Date: |
Tue, 16 Jun 2020 17:58:50 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Danny Milosavljevic writes:
Hi Danny,
> are you sure about the following?
>
> (define (i386:r-word-mem-add info v)
> (let ((r (get-r info)))
> `((,(string-append "addw___$i8,(%" r ")") (#:immediate2 ,v)))))
> ^^^ ^
Ah, yes that shoud be $i16.
> DEFINE addw___$i8,(%eax) 668100
> DEFINE addw___$i8,(%ebx) 668103
>
> Compare:
>
> (define (i386:r-byte-mem-add info v)
> (let ((r (get-r info)))
> `((,(string-append "addb___$i8,(%" r ")") (#:immediate1 ,v)))))
>
> DEFINE addb___$i8,(%eax) 8000
> DEFINE addb___$i8,(%ebx) 8003
>
> I guess it doesn't matter much what the M1 macro is called, but for
> consistency I suggest $i16 for the addw.
Yes, sure! Good catch :-)
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com