[bug-mdk] [bug #40359] mdk-1.2.7/mixlib/xmix_vm.c:442: possible bad if test ?

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?40359>

                 Summary: mdk-1.2.7/mixlib/xmix_vm.c:442: possible bad if test
?
                 Project: GNU MIX Development Kit
            Submitted by: dcb314
            Submitted on: Thu 24 Oct 2013 08:38:02 GMT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Source code is

  g_assert (ins->opcode >= mix_opJAx || ins->opcode <= mix_opJXx);

Suggest swap || for &&

gcc compiler flag -Wlogical-op said

xmix_vm.c:442:3: warning: logical 'or' of collectively exhaustive tests is
always true [-Wlogical-op]





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40359>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/