[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-mcron] tests/schedule.sh issues
From: |
Mathieu Lirzin |
Subject: |
Re: [Bug-mcron] tests/schedule.sh issues |
Date: |
Tue, 20 Mar 2018 19:30:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
>> address@hidden (Ludovic Courtès) writes:
>>
>>> There’s a couple of issues with tests/schedule.sh in mcron 1.1:
>>>
>>> 1. It expects to be running in a UTC+1 timezone. I think that can be
>>> enforced by doing “export TZ=UTC-1”, at least on GNU systems.
Fixed in commit 09e452b62a82845736e638eecd762a911d95a349
>>> 2. It relies on non-deterministic behavior. Specifically, the order
>>> in which ‘mcron --schedule’ shows the foo.guile and the bar.guile
>>> jobs relies on the order in which files are traversed by
>>> ‘for-each-file’, which is non-deterministic.
>>>
>>> The fix would be to write ‘for-each-file’ along these lines:
>>>
>>> (define (for-each-file proc directory)
>>> (for-each proc (scandir directory)))
>>>
>>> because ‘scandir’ sorts entries.
Fixed in commit f908c5395c24da621e5e30814a7a3e4fb76abcbc
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37