[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Check .exe as well when a target does not exist on OS/2

From: KO Myung-Hun
Subject: Re: [PATCH] Check .exe as well when a target does not exist on OS/2
Date: Sat, 14 Jan 2023 23:40:57 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2


Eli Zaretskii wrote:
>> From: KO Myung-Hun <komh78@gmail.com>
>> Date: Fri, 13 Jan 2023 22:27:43 +0900
>> For example,
>> foo: foo.c
>>     gcc $@ $<
>> This pattern is usually used on UNIX. However, on OS/2, gcc creates
>> foo.exe not foo when an extension is not present, and Make check foo
>> only. Therefore Make tries to build foo whenever called.
> Please describe the use case in detail.  This situation exists on
> other platforms, not just of OS/2, and we don't do anything like that
> for those other targets, AFAIK.  Instead, the Makefile should use
> $(EXEEXT) or somesuch to account for the issue.  I don't see why OS/2
> should be handled differently.  But maybe I'm missing something.

Yes, I appended $(EXEEXT) if necessary for libiconv, coreutils, and so
on. BTW, I had a question while doing that. Because only OS/2 required
$(EXEEXT). Windows platform such as mingw also requires it, but until I
appended, it had not been there. In practice, make of mingw does not
require $(EXEEXT).

So I made this patch.

> In general, settling for 'foo.exe' when the target is 'foo' can easily
> cause false positives, so such a change should IMO not be introduced
> without a serious discussion of the possible downsides and
> regressions.

I agree.


KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.40 on Intel Core i7-3615QM 2.30GHz with 12GB RAM

Korean OS/2 User Community : http://www.os2.kr/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]