[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] Introduce $(compare ...) for numerical comparison

From: Paul Smith
Subject: Re: [PATCH 3/3] Introduce $(compare ...) for numerical comparison
Date: Sat, 27 Nov 2021 23:02:49 -0500
User-agent: Evolution 3.36.5-0ubuntu1

On Mon, 2021-11-15 at 20:49 +0100, Jouke Witteveen wrote:
> It may be obscure, but how about we implement this as well? Sure, the
> two-argument form of $(compare) will be a little inconsistent, but it
> may be useful.

I applied this three-patch set.

I left the argument order as you originally specified it, and I added
support for a 2-argument form that provides a trivial equality as
above.  Maybe it's weird but I think it might be useful.

The one change I made is changing the name of the function from
"compare" to "intcmp": I felt "compare" was too generic.  Sometime we
may want to introduce other types of comparison such as "strcmp" etc.

Let me know what you think about this: I've only applied it to my local
Git repository but not pushed it yet.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]