Re: [bug #60774] make hangs on fcntl lock when using -O and stdout is /dev/null

[Dmitry Goncharov]

On Saturday, July 24, 2021, Eli Zaretskii <INVALID.NOREPLY@gnu.org> wrote:
> Follow-up Comment #5, bug #60774 (project make):
>
> The MS-Windows port of GNU Make doesn't lock stdout (or any other standard
> device).  Instead, it uses a mutex to synchronize output.  So I think this
> problem cannot happen on Windows.

True. 

> But I see that your changeset touches quite a few places in the code which is
> Windows specific, and I wonder why did you have to do that, since the problem
> you are trying to fix doesn't exist there.  Wouldn't it be more prudent to
> leave the Windows-only code alone?

The windows code, which passes down the semaphore to children is reused to pass down the fd on unix. If we leave it alone, we'd have to duplicate the mechanism on unix.

Regards, Dmitry

>     _______________________________________________________
>
> Reply to this item at:
>
>   <https://savannah.gnu.org/bugs/?60774>
>
> _______________________________________________
>   Message sent via Savannah
>   https://savannah.gnu.org/