Re: Noisy compile on Fedora 28, x86_64

[Jeffrey Walton]

On Fri, Aug 24, 2018 at 5:33 PM, Martin Dorey
<address@hidden> wrote:
> I think that's essentially the same issue as the failed compile one.  The
> bug I linked to there links to a mail thread that links to this mail thread:
>
> http://gnu-make.2324884.n4.nabble.com/undefined-reference-to-alloca-td18308.html
>
> If you look at Earnestly's patch there, it bears quite a resemblance to part
> of this large change:
>
> http://git.savannah.gnu.org/cgit/make.git/diff/?id=63b42fa235835cbeac6c1b9182f32798ea135dfd
>
> ... a part that went unremarked upon in the check-in comment, specifically
> the part that does "#if !defined __alloca".  Maybe you could cherry pick
> that part.  Is it really two years since the last release?

Oh my goodness... I searched for <alloca.h> and said WTF??? I don't
even want to know why things are done that way.

Here's what I am trying to cut-in. It is a little more tradition and
should just work.

$ git diff
diff --git a/configure.ac b/configure.ac
index 31a00a6..4480226 100644
--- a/configure.ac
+++ b/configure.ac
@@ -73,7 +73,7 @@ AC_HEADER_STDC
 AC_HEADER_DIRENT
 AC_HEADER_STAT
 AC_HEADER_TIME
-AC_CHECK_HEADERS([stdlib.h locale.h unistd.h limits.h fcntl.h string.h \
+AC_CHECK_HEADERS([stdlib.h locale.h unistd.h limits.h fcntl.h
string.h alloca.h \
                   memory.h sys/param.h sys/resource.h sys/time.h sys/timeb.h \
                   sys/select.h sys/file.h spawn.h])

diff --git a/lib/glob.c b/lib/glob.c
index f221a53..96783d4 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -30,6 +30,10 @@ USA.  */
 # define _GNU_SOURCE   1
 #endif

+#ifdef HAVE_ALLOCA_H
+# include <alloca.h>
+#endif
+
 #include <errno.h>
 #include <sys/types.h>
 #include <sys/stat.h>