Strangeness in w32/subproc/sub_proc.c

[Gisle Vanem]

Some lines in this file seems a bit strange.
Line 755:

 if (arr2envblk(envp, &envblk, &envsize_needed) == FALSE) {
            pproc->last_err = 0;  << !!
            pproc->lerrno = E_NO_MEM;
            free( command_line );
            if (pproc->last_err == ERROR_INVALID_PARAMETER
               && envsize_needed > 32*1024) {

With the above, the 'if (pproc->last_err ..' test will never
be hit. So the "pproc->last_err = 0" should be put after
the warning. Patch attached.

PS. The test on ERROR_MORE_DATA is important too IMHO.

--
--gv

sub_proc.diff
Description: Text document