bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #46261] missing usage of EINTRLOOP macro


From: Jack Howarth
Subject: [bug #46261] missing usage of EINTRLOOP macro
Date: Wed, 21 Oct 2015 02:18:40 +0000
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.7 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.7

Follow-up Comment #1, bug #46261 (project make):

The change...

diff -uNr make-4.1.orig/main.c make-4.1/main.c
--- make-4.1.orig/main.c        2014-10-05 12:24:51.000000000 -0400
+++ make-4.1/main.c     2015-10-20 22:08:00.000000000 -0400
@@ -3364,9 +3364,12 @@
 #else
       /* Close the write side, so the read() won't hang.  */
       close (job_fds[1]);
-
-      while (read (job_fds[0], &token, 1) == 1)
+      int r;
+      EINTRLOOP (r, read (job_fds[0], &token, 1));
+      while (r == 1) {
         ++tcnt;
+       EINTRLOOP (r, read (job_fds[0], &token, 1));
+      }
 #endif
 
       if (tcnt != master_job_slots)

seems to eliminate the failures here on OS X 10.12.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46261>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]