bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix output-sync option on EMX - updated


From: Pavel Fedin
Subject: [PATCH] Fix output-sync option on EMX - updated
Date: Wed, 15 Jan 2014 10:23:58 +0400

 Hello!

> Thanks, but does EMX support output-sync?  If not, this fragment:
> 
>   +      /* Divert child output if output_sync in use.  */
>   +      if (child->output.syncout)
>   +        {
>   +          if (child->output.out >= 0)
>   +            outfd = child->output.out;
>   +          if (child->output.err >= 0)
>   +            errfd = child->output.err;
>   +        }
>   +
> 
> should be conditioned on NO_OUTPUT_SYNC.  Otherwise we are breaking the
> EMX build of Make.

 I have rechecked. Actually NO_OUTPUT_SYNC is defined only by handmade
config.h files for DOS, VMS and Amiga. EMX uses configure script, so
NO_OUTPUT_SYNC will not be defined.
However, indeed, there is rational seed in what you say. Since this code
actually goes to generic part, it will be useful to be able to disable this
code, just in case.
 Please take the updated patch. I have verified it to build by supplying
CPPFLAGS=-DNO_OUTPUT_SYNC to configure.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

Attachment: make-fix-output-sync-emx.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]