bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32


From: Derek Buitenhuis
Subject: [bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
Date: Wed, 08 May 2013 23:36:32 +0000
User-agent: Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.64 Safari/537.31

URL:
  <http://savannah.gnu.org/bugs/?38945>

                 Summary: [PATCH] Fix CRLF backslash-newline handing on
non-WINDOWS32 platforms
                 Project: make
            Submitted by: dwbuiten
            Submitted on: Wed 08 May 2013 11:36:31 PM GMT
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: SCM
        Operating System: POSIX-Based
           Fixed Release: None
           Triage Status: None

    _______________________________________________________

Details:

Attached is a patch that will fix erroneous parsing for Makefile with CRLF
line endings, and a backslash-newline before a rule/prefix name (which POSIX
says should is allowed and should be ignored).

Example case:

http://git.libav.org/?p=libav.git;a=blob;f=libavcodec/x86/Makefile;h=f13f3e0ea8f45efb9050ff7439d7e2de108778d0;hb=HEAD#

When cloned on windows with autocrlf set to true, you get the following with
MSYS Make:

common.mak:129: *** missing separator.  Stop.

Also reproducible on Linux with CRLF endings.

The attached patch fixes the issue on non-WINDOWS32 platforms such as Linux
and MSYS. Comments and opinions welcome!

- Derek



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 08 May 2013 11:36:31 PM GMT  Name:
0001-Fix-CRLF-backslash-newline-handing-on-non-WINDOWS32-.patch  Size: 781B  
By: dwbuiten
Fix
<http://savannah.gnu.org/bugs/download.php?file_id=28051>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38945>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]