[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-mailutils] Patches 2525 and 2526

From: Sergey Poznyakoff
Subject: [bug-mailutils] Patches 2525 and 2526
Date: Mon, 26 Jan 2004 12:53:38 +0200

Hello Daniel,

Thanks a lot for your effort. The proposed patches[1] are a good start,
however there are several problems with them:

1) No checking whether IPv6 functions are present on the
system (your comments show that you are planning to work on this).

2) Too much code duplication which would make it difficult to maintain.

Ideally, both IPv4 and IPv6 code should be hidden behind a common
wrapper[2], where IPv6 code would be properly protected by #ifdef #endif
(of course, configure should have option --without-ipv6). The best place
for such wrapper code would probably be in mailbox/. Then only the
minimum amount of modifications would be needed for the existing daemons
and IPv6 functions would become easily accessible to libmailbox users
as well.

I hope this will help you in improving the patches.


[1] http://sv.gnu.org/patch/?func=detailitem&item_id=2525

[2] The common wrapper function might look like this:

mu_poll (list_t addrlist,
         int (*handler) (enum mu_ip_event ev, int fd, void *closure_data),
         void *closure_data); 

mu_ip_event is supposed to carry information about the status of fd
(ready for writing/ready for reading/exception), and addrlist a list
of list of interface addresses to listen on. Of course, that's only
a sample, right off the top of my head. Maybe the interface should be
more complex...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]