[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-mailutils] maildir patch (based on 0.4)
From: |
Sergey Poznyakoff |
Subject: |
Re: [bug-mailutils] maildir patch (based on 0.4) |
Date: |
Tue, 04 Nov 2003 00:49:40 +0200 |
Hi,
Thanks again for your patch. I've finally managed to test reading and
adding to the mailbox. Good job. The patch seems to work OK, though
there are several notes:
1) The return value from opendir() is always used without checking,
which leads to coredump if one of the subdirs "cur", "tmp" or "new"
does not exist. A check for (errno==ENOENT) should follow, and if
it succeeds, mkdir should be called.
2) The function _mh_delim() is entirely MH-specific and irrelevant to
maildir. For maildir, the usual test str[0]=='\n' will suffice.
3) In _maildir_message_save a part of code saving X-IMAP-Base
header is commented out with a notice /* no IMAP needed in maildir*/,
which I don't quite understand. X-IMAP-Base may be needed no matter
what the mailbox format is.
Apart from that, everyhting is OK. I haven't tested the locking
and NFS interaction issues, though.
A side note: generally speaking, I'd like it to be better integrated to
the overall structure. I thought it was going to be very similar to MH,
and yet it has overcome my expectations: so much MH code is duplicated
in maildir that I'm going to move their "common denominator" to
mailbox, which will probably reduce both libmh and libmaildir sources
to some 100-200 lines of code.
I'll write more on it when I'm through doing tests.
Thank you,
Sergey