[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-mailutils] [PATCH] SASL fix

From: Simon Josefsson
Subject: Re: [bug-mailutils] [PATCH] SASL fix
Date: Mon, 03 Feb 2003 10:29:56 +0100
User-agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2 (i386-debian-linux-gnu)

Sergey Poznyakoff <address@hidden> writes:

> Hi Simon,


>> Some SASL mechanisms output data when GSASL_OK is returned (data which
>> doesn't affect the outcome of the SASL negotiation, typically data
>> that provides mutual authentication for the client).  This makes sure
>> it is sent.
> [...]
>> +  if (output_len > 0)
>> +    util_send ("+ %s\r\n", output);
>> +
> Output_len will always be greater then zero, so util_send will be
> called unconditionally. Or did you mean
>   if (output[0])
>     util_send ("+ %s\r\n", output);
> ?

Yes.  Sorry, I confused the interface with how mechanisms internally
in libgsasl work -- they set the output_len variable too.

The step and encode/decode interfaces will probably be changed in the
future to return newly allocated strings instead -- looping around the
function when it returns GSASL_TOO_SMALL_BUFFER generates ugly code
both in the application and in libgsasl.  (But don't worry: the old
API will continue to work for a long time, so no need to redo any of
your work.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]