bug-mailutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-mailutils] Re: [PATCH] Support for SASL authentication in imap4


From: Simon Josefsson
Subject: Re: [bug-mailutils] Re: [PATCH] Support for SASL authentication in imap4d
Date: Fri, 17 Jan 2003 22:13:35 +0100
User-agent: Gnus/5.090013 (Oort Gnus v0.13) XEmacs/21.4 (Portable Code, i686-pc-linux)

Sergey Poznyakoff <address@hidden> writes:

> Hello Simon,
>
>> > Simon Josefsson <address@hidden> writes:
> [...]
>> I updated it again, and it seems to still work for GNU SASL 0.0.4.
>> Was any problems with the patch encountered?  
>
> Oops, sorry, I seem to have missed the quoted letter. No, there were
> no special problems with the patch, however I do have several questions:
>
> 1) What was the reason for removing openlog() call from
> imap4d/login.c? It is there (as well as in pop3d) because
> many pam modules call openlog(..., LOG_AUTH), thus disturbing
> the opened syslog channel when pam authentication is used.

My rationale, although given your explanation it is probably not a
good one, was: imap4d/imap.c already calls openlog().

But is it a good solution to require callers of mu_authenticate() to
directly call openlog() again?  It seems the best solution would be to
hide those details in a wrapper somehow.

> 2) Is it so necessary to use pkg-config in order to detect the
> presence of libgsasl? 

Probably not.  Although libgsasl may require libntlm, libgcrypt,
libgssapi, libkrb5 and possibly other libraries, so that would have to
be taken care of somehow.  If mailutils uses libtool, I think it will
take care of it though.

> 3) The patch distributes the sasl-specific portions of code among
> several sources. As you rightly pointed out, the whole sasl
> framework should be implemented within as an opaque module
> within libmuauth library.
>
> I have almost finished (3)

Great news!  This sounds like the right solution.

> however I believe we should wait until TLS support for imap4d is
> added (Wojciech is going to commit it in a matter of days) in order
> to get everything integrated properly.

Yes.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]