Re: mailbox_save_attributes

[Alain Magloire]

> 
> 
> > Done.
> > mailbox_save_attributes()
> > The code is ugly, fortunately the rewrite of the lib will purge
> > some of the cruft.
> 
> Great! Finally, delete/expunge in imap4d works across invocations :^)

[[laughs]]
"Finally" 8-), I'm hurt ... are you saying I was lazy ?  8-)

I still think that rfc2060 is unclear, or rather I did not understand
it fully.  Because it is unclear to me that if the connection
goes away suddenly that the attribute flags should be save still.

But I've seen mozilla/netscape use this all the time, they open
the connection save/change some attributes etc ... close the connection
without the proper "logout".

In my mind, if the session was not properly close no change would
be done to the mailbox.

> I have also added mailbox_save_attributes() to mail/, so it also
> preserves message attributes on exit.
> 
> I just thought that maybe the mbox_expunge() could do the same work, in
> this case we'll make closing the mailbox a lot faster. Or maybe both
> mbox_expunge() and mbox_save_attributes() could use the same function
> that will do the actual work. This is for the new API, of course...

Yes, agree with the analysis(sp?).  Too much duplication, we'll clean
this up.  Also when expunging/appending, It is part of the MBOX(Unix)
format to mangle ^From --> ">From" in the body of the message.
The low-level pop3 is done(mailbox2/pop3). I'll start on mbox(unix)
later this week.

Thanks for the feedback, it helps.

--
alain