Re: sieve: some corrections

[Sam Roberts]

Hey Sergey, thanks.

Like Alain says, thursday nights (sometimes) and weekends are my
play with mailutils times.

[OT] Lifes been crazy lately, too, we got the "1/3 of you are going to get
laid off this morning" email last monday. The developers almost all stayed,
but everything is upside down. Kindof surreal, really, first time for me.
Tough times for some.


Quoting Sergey Poznyakoff <address@hidden>, who wrote:
> Bonjour,
> 
> Maybe the following changes would allow to better integrate sieve
> in the project. The patch below addresses the following:
> 
>   1. configure.in: AC_PROG_YACC and AM_PROG_LEX are needed.

I'll do.

>   2. sieve/Makefile.am:
>    * It seems unwise to list `test' in bin_PROGRAMS, its name
>      coincides with the shell command and will thus cause problems
>      when the packet is configured with --prefix=/

Yep, I might just take it out. test is what came with cmu-sieve,
as it's example app. It doesn't do anything that sieve doesn't.

>    * Header files were not listed in any of the _SOURCES and thus
>      did not get distributed.

Thanks. I've never done anything but tweaked autoconf/make stuff, I
don't actually know how it's all supposed to work.

>    * Use of slightly modified ylwrap scripts facilitates inclusion
>      of multiple grammars/lexers in a program.
Makes sense.

>   3. sieve/sieve.c: EOK is not defined on some systems.

Yeah, I recalled that when compiling on my linux box at work.

I'll put this in tomorrow or Saturday.

Alain suggested NOT makeing sieve get built and distributed from
the top level make file, that's why I didn't patch the root
Makefile.am or configure.in. I haven't got it to the point that
I can run it automatically at work to do what I need. When it works
for me I'll be a little more happy suggesting it might work for
other people, personally.

I have to run, but I'm not dead or ignoring this!

Thanks,
Sam

> Some words about ylwrap: it is a modified version of the wrapper from
> automake-1.4, it differs from the standard one in that it accepts an
> optional switch -yy repl which allows to replace yy.* identifiers in
> a uniform way, whether system's yacc/lex support -p feature or no. The
> text of ylwrap follows the patches. It is supposed that ylwrap lives
> in sieve subdirectory.
> 
> 
> Cheers,
> Sergey

-- 
Sam Roberts <address@hidden> (Vivez sans temps mort!)