[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug? with Choir Staff
From: |
Janek Warchoł |
Subject: |
Re: bug? with Choir Staff |
Date: |
Fri, 24 Aug 2012 00:03:03 +0200 |
On Thu, Aug 23, 2012 at 3:45 PM, David Kastrup <address@hidden> wrote:
> Janek Warchoł <address@hidden> writes:
>> just FYI, the barline problem was fixed in 2.15.10 (commit
>> b92ea16ef75d8aaa7bdb9f492b58d7af906e7945).
>
> While it will likely catch most uses, bar_line_color == staff_color is
> mixing C operators and only compares for strict eq-equivalence. It
> might make more sense to write
>
> ly_is_equal (bar_line_color, staff_color)
>
> here instead.
I understand that you refer to how it should be done in c++ code?
I mean, this has been ported to Scheme entirely
(deafba084c8ecf6af02f64455856147821b598c7), and the logic is now in
scm/bar-line.scm, line 356. I don't see your comment being applicable
to this new scheme code - am i missing something?
Janek
- bug? with Choir Staff, Aaron, 2012/08/21
- Re: bug? with Choir Staff, Reinhold Kainhofer, 2012/08/21
- Re: bug? with Choir Staff, Colin Hall, 2012/08/21
- Re: bug? with Choir Staff, Xavier Scheuer, 2012/08/22
- Re: bug? with Choir Staff, Aaron Laws, 2012/08/22
- Re: bug? with Choir Staff, Colin Hall, 2012/08/23
- Re: bug? with Choir Staff, David Kastrup, 2012/08/23
- Re: bug? with Choir Staff, Aaron Laws, 2012/08/23
- Re: bug? with Choir Staff, Janek Warchoł, 2012/08/23
- Re: bug? with Choir Staff, David Kastrup, 2012/08/23
- Re: bug? with Choir Staff,
Janek Warchoł <=
- Re: bug? with Choir Staff, David Kastrup, 2012/08/30