[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: horizontal spacing regression
From: |
Keith OHara |
Subject: |
Re: horizontal spacing regression |
Date: |
Fri, 14 Jan 2011 15:07:35 -0800 |
User-agent: |
Opera Mail/11.00 (Win32) |
On Fri, 14 Jan 2011 03:34:33 -0800, Carl Sorensen <address@hidden> wrote:
On 1/14/11 4:20 AM, "Joe Neeman" <address@hidden> wrote:
On Fri, Jan 14, 2011 at 11:57 AM, Carl Sorensen <address@hidden> wrote:
[...]
So it seems that making this change affects a desired behavior (as described
in a regtest). If, in your opinion, the output is better overall with the
new behavior, we should probably do the following:
1) Have a discussion on -devel, with images shown before and after
2) Change something about the description of spacing-horizontal-skyline.ly
<http://spacing-horizontal-skyline.ly>
to indicate under which conditions tucking is *not* allowed.
[...]
I think you'll find that the regression was caused by ee0488, in which case
the extra-spacing-height override is exactly the thing to do if you want to
restore the old behaviour. It's really just a question of how much padding to
add; I don't think it's worth a long discussion.
1) I was looking through music for examples last evening. I can show a couple
images showing the relevant situations, with 'extra-height >= x would un-tuck'
to start a short discussion over on -devel.
(Probably three hours from now, as the sun is out today and still up here.)
2) that reg-test contains seven overlap situations; half tuck and half don't.
The first guess value of extra-spacing-height changed one on the border.
Have you explored its affects with multiple accidentals? Does it cause
problems, e.g. with a key signature?
LilyPond's reg-test suite include these things (big time) and were unchanged.
I'll watch for it while collecting examples.
In your opinion, should we make it part of the Accidental default
properties?
I think we will be happier with 2.14 with a bit of padding, otherwise some
scores look noticeably worse than with 2.12. It's not a big deal in my mind,
but I was motivated enough to test and collect examples, and fishing for
other opinions. Back in a couple short hours,
-keith
Re: horizontal spacing regression, Phil Holmes, 2011/01/14
Re: horizontal spacing regression, Keith OHara, 2011/01/14