Re: Issue 1103 in lilypond: Typo in engraver name while defining new contexts causes lilypond to segfault

[lilypond]

Comment #2 on issue 1103 by n.puttock: Typo in engraver name while defining  
new contexts causes lilypond to segfault
http://code.google.com/p/lilypond/issues/detail?id=1103

Hi Benjamin,

Thanks for producing this patch so quickly.

Here are a few comments:

+\version "2.12.0"

"2.13.23"

The regression test is too complicated; since the segfault doesn't depend  
on creating
a new context, the \layout block could be boiled down to the following  
(thus also
simplifying the music block):

\layout {
  \context {
    \Voice
    \consists "Rhythmic_column_engraver_foo"
  }
}

Since this regtest produces a warning, we need to ensure it doesn't break  
in the
(distant) future once we're able to set 'warning-as-error to #t:

#(ly:set-option 'warning-as-error #f)

+      bool is_scheme = true;

I think this would be better defaulting to false, since the majority of  
engravers are
defined in C++.

Cheers,
Neil