[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-libunistring] Test suite patches to clear Asan findings

From: Bruno Haible
Subject: Re: [bug-libunistring] Test suite patches to clear Asan findings
Date: Tue, 14 May 2019 02:04:10 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-145-generic; KDE/5.18.0; x86_64; ; )

Hi Jeffrey,

> The attached patch clears Asan findings in libunicode 0.9.10. The
> patch allows the library to pass acceptance testing with no findings
> or errors.

Thanks. I think most your changes duplicate those that were already
committed in gnulib two months ago. [1]

I don't know whether your mail only intended to indicate which tests
have memory leak, or whether you proposed your patch for inclusion.
In the latter case, be aware that you would first have had to reword
the patch
  1. to follow GNU coding style, in particular regarding the placement
     of braces,
  2. the idiom
       if (result)
         free (result);
     is not acceptable in tests, because
       - SunOS 4 is no longer among our porting targets,
       - simplicity of the code is more important than micro-optimizations,
         in tests.

> I am not sure about tests/test-float.c.

Just disabling a piece of test code is not the right way.
If you want to spend time investigating it, please do so in depth.
If you don't want to spend time investigating it, just let the test continue
to fail.
When we last talked about this failure, I indicated that it's not of high
priority for me.


[1] https://lists.gnu.org/archive/html/bug-gnulib/2019-03/msg00025.html

reply via email to

[Prev in Thread] Current Thread [Next in Thread]