[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-libunistring] lib/stdint.mini.h -- bug?
From: |
Bruno Haible |
Subject: |
Re: [bug-libunistring] lib/stdint.mini.h -- bug? |
Date: |
Tue, 1 Jun 2010 22:58:57 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Ben,
Ben Pfaff wrote:
> I guess that the file doesn't have 64-bit definitions
> because libunistring doesn't need them yet and they would require
> additional tests?
Correct. This file is a trimmed-down version of gnulib's <stdint.h>,
designed in a way that it does not need autoconf tests that depend
on the compiler and therefore works with any compiler brand.
> Following this comment:
>
> /* 7.18.1.1. Exact-width integer types */
>
> this file has similar stanzas for 8-, 16-, and 32-bit types, but
> then it #undefs macros for 8-, 32-, and 64-bit types. Based on
> symmetry, this makes me think that there should be an #undef for
> a 16-bit macro, and possibly not for a 64-bit macro.
The #defines are needed for interoperability with Solaris 2.5.1
<pthread.h>. This file tests _UINT8_T, _UINT32_T, _UINT64_T.
Apparently the pthread implementation on Solaris does not need
16-bit integer types.
But you are right regarding _UINT64_T. I've corrected this now:
http://git.savannah.gnu.org/gitweb/?p=libunistring.git;a=commitdiff;h=c8337fee8bd30207245f67201a9b4559f10ca91c
Bruno