[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-libunistring] Fix quoting in exported.sh.in, allow multiple arg

From: Bruno Haible
Subject: Re: [bug-libunistring] Fix quoting in exported.sh.in, allow multiple arguments.
Date: Fri, 1 May 2009 13:53:04 +0200
User-agent: KMail/1.9.9

Hi Ralf,

> Quote argument to eval, to avoid losing TABs from @GLOBAL_SYMBOL_PIPE@

Hmm. I used exactly the same kind of quoting as libtool. Namely, the
configure file contains the following code, expanded from libtool.m4:

    # Now try to grab the symbols.
    if { (eval echo "$as_me:$LINENO: \"$NM conftest.$ac_objext \| 
$lt_cv_sys_global_symbol_pipe \> $nlist\"") >&5
  (eval $NM conftest.$ac_objext \| $lt_cv_sys_global_symbol_pipe \> $nlist) 2>&5

If here the contents of lt_cv_sys_global_symbol_pipe is first subject to
word expansion and then to 'eval', it can't be wrong if exported.sh does
the same?

Regarding quoting, probably I need to avoid evaluating the argument
string, i.e. write

  nm_cmd="@NM@ \$1 | @GLOBAL_SYMBOL_PIPE@"


  nm_cmd="@NM@ \$* | @GLOBAL_SYMBOL_PIPE@"

> The multi-file change allows for further improvements to the build
> system.

What other changes do you have in mind? Or do you want to reuse exported.sh
in automake?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]