|
From: | Eric Blake |
Subject: | [bug-libsigsegv] Re: [PATCH] Fix powerpc64-unknown-linux-gnu implementation. |
Date: | Mon, 25 Oct 2010 10:45:03 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 10/24/2010 04:19 PM, Bruno Haible wrote:
I wrote:By the way, stackvma-mincore.c uses a little more than 2048 bytes on the stack, but that should be OK.On some platforms, the minimum SIGSTKSZ is only 2 KB. So this will be needed as well:
In fact, on Linux in general, MINSIGSTKSZ is 2 KB; and while we recommend that libsigsegv users use SIGSTKSZ instead of MINSIGSTKSZ, we might as well try to be accommodating.
--- src/stackvma-mincore.c.orig Mon Oct 25 00:16:34 2010 +++ src/stackvma-mincore.c Sun Oct 24 19:31:47 2010 @@ -78,7 +78,7 @@ { /* Use a moderately sized VEC here, small enough that it fits on the stack (without requiring malloc). */ - pageinfo_t vec[2048]; + pageinfo_t vec[1024];
I folded this in, and pushed. -- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |