Re: [PATCH] Updating homepage to point people to pagure for development.

[Yuchen Pei]

Yuchen Pei <hi@ypei.me> writes:

> Yuchen Pei <hi@ypei.me> writes:
>
> > jahoti <jahoti@envs.net> writes:
> >
> > > On 10/13/21 3:32 AM, Yuchen Pei wrote:
> > > > If we were to evaluate pagure.io based on the ethical 
> > > > repository
> > > > criteria[1] it would probably get an F for failing C0, 
> > > > because
> > > > with 
> > > > LibreJS on I couldn't register a new account, nor could I 
> > > > create a
> > > > pull request.
> > >
> > > Couldn't you?
> >
> > When I tried to register, I couldn't navigate to the "register 
> > tab"
> > from the "login tab".
> >
> > After a second look, I was not sure about creating a pull
> > request. When I click "create a pull request", I see an empty 
> > page,
> > with 10 scripts blocked.  But that could also be I don't have a
> > commit
> > on my fork yet.
> >
> > So I tried to push my commit to my fork so that I can create a 
> > PR,
> > but
> > that seems to require adding an ssh key, which I cannot do with
> > LibreJS on: clicking "Add SSH key" does nothing.
> >
> > I went to private browsing where librejs is disabled to add a 
> > key,
> > pushed my commit to my fork[1], and came back to my main 
> > browser
> > without private browsing.  I am still not able to create a PR, 
> > as the
> > button is disabled, and "Files changed" and "Commits" both show 
> > a
> > count of 0 - see the attached screenshot.
> >
> > [1]:
> > https://pagure.io/fork/ycp/librejs/c/fadb9a896a11ba929476cc5adb5f4a35815cedd0?branch=fix-json-parsing
>
> I just noticed the screenshot shows ycp/master.  That is because
> trying to change it to the correct branch (ycp/fix-json-parsing) 
> does nothing - it stays at the master branch.

There are 10 scripts blocked for me by LibreJS (version 7.20.2) on 
that page:

> blocked scripts in 
> https://pagure.io/fork/ycp/librejs/diff/master..master:

> <SCRIPT> at line 433 of 
> https://pagure.io/fork/ycp/librejs/diff/master..master:

> NONTRIVIAL: nontrivial token: 'history'
> <SCRIPT> at line 448 of 
> https://pagure.io/fork/ycp/librejs/diff/master..master:

> NONTRIVIAL: nontrivial token: 'setTimeout'
> <SCRIPT> at line 583 of 
> https://pagure.io/fork/ycp/librejs/diff/master..master:

> NONTRIVIAL: nontrivial token: 'document'
> https://pagure.io/static/vendor/selectize/selectize.min.js:

> External script with no known license
> https://pagure.io/static/vendor/jquery.textcomplete/jquery.textcomplete.min.js:

> External script with no known license
> https://pagure.io/static/vendor/emojione/emojione.min.js:

> External script with no known license
> https://pagure.io/static/emoji/emojicomplete.js:

> External script with no known license
> https://pagure.io/static/vendor/jquery.caret/jquery.caret.min.js:

> External script with no known license
> https://pagure.io/static/vendor/jquery.atwho/jquery.atwho.min.js:

> External script with no known license
> https://pagure.io/static/request_ev.js:

> External script with no known license


> > > It worked for me using NoScript with an empty whitelist
> > > and scripts blocked.
> > >
> > > Either way, I agree reports should be accepted from the GNU 
> > > mailing
> > > list.


--
Best,
Yuchen

PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.me/assets/ypei-pubkey.txt>

signature.asc
Description: PGP signature