[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How to check for perl or usable printf tools?

From: Simon Josefsson
Subject: Re: How to check for perl or usable printf tools?
Date: Sun, 25 Sep 2022 11:47:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Erik Auerswald <auerswal@unix-ag.uni-kl.de> writes:

> Hello Simon,
> On 25.09.22 11:19, Simon Josefsson wrote:
>> Erik Auerswald <auerswal@unix-ag.uni-kl.de> writes:
>>> Hi all,
>>> On Mon, Sep 12, 2022 at 12:45:32PM +0200, Erik Auerswald wrote:
>>>> On Mon, Sep 12, 2022 at 05:16:00AM -0400, Alfred M. Szmidt wrote:
>>>>>     > I am trying to use the reported input file that crashes tftp for
>>>>>     > the test.  This file contains non-printable characters (i.e.,
>>>>>     > it is a "binary" file).  I do not want to add this binary file
>>>>>     > as-is to the git repository.
>>>>>     Why?  I don't see anything fundamentally wrong with commiting a
>>>>>     binary fuzz file that trigger som particular bad behaviour.
>>>>> Yeah, the other solution are far more cumbersome to maintain than a
>>>>> binary file.
>>>> OK, then I'll change the tftp-regressions.sh test to directly use the
>>>> binary input from the fuzzer.
>>> I have just done this, see commit d3270b73ecf1207d30d852ecc50119cbc4422464.
>> Thank you!
>> I committed some minor fixes to make CI/CD build, see
>> https://gitlab.com/jas/inetutils/-/pipelines/
> Your changes to tests/tools.sh did not make it into the attached
> patch or the GNU Inetutils git repository, because it is generated
> from tests/tools.sh.in.  It would be great if you could add them
> there.

Oops, should be fixed now.  The design of tests/tools.sh.in seems
sub-optimal to me, it would be nicer to not use a *.in script and put
the necessary tool paths in environment variables from tests/Makefile.am


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]