[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] telnet: Fix silent truncation (off-by-one check)
From: |
Tim Rühsen |
Subject: |
[PATCH] telnet: Fix silent truncation (off-by-one check) |
Date: |
Sun, 16 Feb 2020 19:26:31 +0100 |
If the DISPLAY variable had exactly 44 bytes, the SE
byte (end sub negotiation) was silently truncated.
---
telnet/telnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/telnet/telnet.c b/telnet/telnet.c
index 297ae0e4..9f8c871f 100644
--- a/telnet/telnet.c
+++ b/telnet/telnet.c
@@ -1010,7 +1010,7 @@ suboption (void)
* protocol must remain unsevered. Check that DP fits in
* full within TEMP. Otherwise report buffer error.
*/
- if (strlen (dp) > sizeof (temp) - 4 - 2)
+ if (strlen (dp) >= sizeof (temp) - 4 - 2)
{
printf ("lm_will: not enough room in buffer\n");
break;
--
2.25.0
- [PATCH] telnet: Fix silent truncation (off-by-one check),
Tim Rühsen <=