Re: [PATCH v2 hurd] rumpusbdisk: Add USB mass storage translator

[Samuel Thibault]

Hello,

Damien Zammit, le mer. 28 juin 2023 10:52:10 +0000, a ecrit:
> diff --git a/rumpdisk/Makefile b/rumpdisk/Makefile
> index b59aaf9a..ab763570 100644
> --- a/rumpdisk/Makefile
> +++ b/rumpdisk/Makefile
> @@ -15,7 +15,9 @@

Nice, thanks for the factorization!

>  HURDLIBS = machdev ports trivfs shouldbeinlibc iohelp ihash fshelp
> -LDLIBS += -lpthread -lpciaccess -ldl
> -LDLIBS += -Wl,--whole-archive $(RUMPLIBS:%=-l%_pic) -Wl,--no-whole-archive 
> $(RUMPEXTRA:%=-l%_pic)
> +
> +rumpdisk-OBJS = $(SRCS:.c=.disk.o)
> +rumpdisk-LDLIBS = -lpthread -lpciaccess -ldl -Wl,--whole-archive 
> $(RUMPLIBS:%=-l%_pic) $(RUMPSATA:%=-l%_pic) -Wl,--no-whole-archive 
> $(RUMPEXTRA:%=-l%_pic)

Better factorize the common LDLIBS parts.

> +extralibs = \
> +     ../libmachdev/libmachdev.a \
> +     ../libports/libports.a \
> +     ../libtrivfs/libtrivfs.a \
> +     ../libshouldbeinlibc/libshouldbeinlibc.a \
> +     ../libiohelp/libiohelp.a \
> +     ../libihash/libihash.a \
> +     ../libfshelp/libfshelp.a

This is linking everything statically. Can't we just pass -lmachdev
-lports etc.? (actually, $(HURDLIBS:%=-l%)

Samuel