Re: [PATCH gnumach] Unmask irq 12 - fixes stuck console with apic

[Samuel Thibault]

Hello,

Damien Zammit, le dim. 19 févr. 2023 02:24:12 +0000, a ecrit:
> ---
>  i386/i386at/model_dep.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/i386/i386at/model_dep.c b/i386/i386at/model_dep.c
> index baff8da1..73b99f94 100644
> --- a/i386/i386at/model_dep.c
> +++ b/i386/i386at/model_dep.c
> @@ -177,6 +177,8 @@ void machine_init(void)
>  #warning FIXME: Rather unmask them from their respective drivers

See this warning :)

>       /* kd */
>       unmask_irq(1);
> +     /* mouse ? */
> +     unmask_irq(12);

We really need to understand what's happening. Is it just the mouse or
also the keyboard which is stuck? Is the keyboard really going through
IRQ 12? Is that ps/2? How is IRQ12 actually getting routed to keyboard?
I see it plugged only on mouseopen call, is that really what eventually
makes your keyboard work at all?

>       /* com0 */
>       unmask_irq(4);
>       /* com1 */